Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/SK-583 | Bump grpcio and grpcio-tools #487

Closed
wants to merge 3 commits into from

Conversation

stefanhellander
Copy link
Collaborator

Description

Bump grpcio and grpcio-tools to latest versions. Update setup.py to support 3.11, 3.12, removed 3.7.

@Wrede
Copy link
Member

Wrede commented Nov 15, 2023

I know grpcio 1.57 works with tensorflow-cpu==2.13.1 and pytorch 1.13. But I think I had problems with 1.58, might be newer versions of tf and torch though that works.

Copy link
Member

@Wrede Wrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fedn installs protobuf 4.25.0 as a dependency of grpcio 1.59. However, when you install tensorflow 2.9 it downgrades protobuf to 3.19.6:

#13 36.36 Attempting uninstall: protobuf
#13 36.36 Found existing installation: protobuf 4.25.0
#13 36.36 Uninstalling protobuf-4.25.0:
#13 36.37 Successfully uninstalled protobuf-4.25.0
#13 47.92 ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
#13 47.92 grpcio-tools 1.59.2 requires protobuf<5.0dev,>=4.21.6, but you have protobuf 3.19.6 which is incompatible.

Tensorflow need to be updated (see my previous comment). Not sure TF supports 1.59.

@Wrede Wrede changed the title Feature/sk-583 Feature/SK-583 | Bump grpcio and grpcio-tools Nov 15, 2023
@Wrede
Copy link
Member

Wrede commented Dec 7, 2023

Closes fix in #490

@Wrede Wrede closed this Dec 7, 2023
@Wrede Wrede reopened this Dec 7, 2023
@stefanhellander stefanhellander deleted the feature/SK-583 branch April 25, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants